Re: [Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-24 Thread Thomas Lamprecht
On 05/23/2016 11:39 PM, Thomas Lamprecht wrote: > Hi, > > sorry for the delay. > > On 20.05.2016 12:06, Gerd Hoffmann wrote: >>Hi, >> >>> ./x86_64-softmmu/qemu-system-x86_64 -boot d -cdrom >>> W7SP1_PROFESSIONAL.iso -m 1024 -smp 2 -enable-kvm -cpu host -drive >>> if=pflash,format=raw,unit=0,rea

Re: [Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-23 Thread Thomas Lamprecht
Hi, sorry for the delay. On 20.05.2016 12:06, Gerd Hoffmann wrote: Hi, ./x86_64-softmmu/qemu-system-x86_64 -boot d -cdrom W7SP1_PROFESSIONAL.iso -m 1024 -smp 2 -enable-kvm -cpu host -drive if=pflash,format=raw,unit=0,readonly,file=OVMF_CODE-pure-efi.fd -drive if=pflash,format=raw,unit=1,fi

Re: [Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-20 Thread Gerd Hoffmann
Hi, > ./x86_64-softmmu/qemu-system-x86_64 -boot d -cdrom > W7SP1_PROFESSIONAL.iso -m 1024 -smp 2 -enable-kvm -cpu host -drive > if=pflash,format=raw,unit=0,readonly,file=OVMF_CODE-pure-efi.fd -drive > if=pflash,format=raw,unit=1,file=/tmp/OVMF_VARS.fd Still not reproduced. Installed win7, then

Re: [Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-17 Thread Thomas Lamprecht
Hi, On 05/17/2016 12:50 PM, Gerd Hoffmann wrote: > Hi, > >>> This way we can allow guests update sr[] registers as they want, without >>> allowing them disrupt vbe video modes that way. >> Just documenting my test with the patch here: >> >> This fixes the issue with QEMU 2.5.1.1 but only if I'm

Re: [Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-17 Thread Gerd Hoffmann
Hi, > > This way we can allow guests update sr[] registers as they want, without > > allowing them disrupt vbe video modes that way. > > Just documenting my test with the patch here: > > This fixes the issue with QEMU 2.5.1.1 but only if I'm using SeaBIOS. > > OVMF leads to a almost similar r

Re: [Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-17 Thread Thomas Lamprecht
Hi, thanks for the patch. On 05/17/2016 10:54 AM, Gerd Hoffmann wrote: > Commit "fd3c136 vga: make sure vga register setup for vbe stays intact > (CVE-2016-3712)." causes a regression. The win7 installer is unhappy > because it can't freely modify vga registers any more while in vbe mode. > > Th

[Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-17 Thread Gerd Hoffmann
Commit "fd3c136 vga: make sure vga register setup for vbe stays intact (CVE-2016-3712)." causes a regression. The win7 installer is unhappy because it can't freely modify vga registers any more while in vbe mode. This patch introduces a new sr_vbe register set. The vbe_update_vgaregs will fill s