Re: [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h

2018-03-27 Thread Auger Eric
Hi, On 28/03/18 03:19, Tiwei Bie wrote: > This macro isn't used by any VFIO code. And its name is > too generic. The vfio-common.h (in include/hw/vfio) can > be included by other modules in QEMU. It can introduce > conflicts. > > Signed-off-by: Tiwei Bie Reviewed-by: Eric Auger Thanks Eric >

Re: [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h

2018-03-27 Thread Michael S. Tsirkin
On Wed, Mar 28, 2018 at 09:19:53AM +0800, Tiwei Bie wrote: > This macro isn't used by any VFIO code. And its name is > too generic. The vfio-common.h (in include/hw/vfio) can > be included by other modules in QEMU. It can introduce > conflicts. > > Signed-off-by: Tiwei Bie Reviewed-by: Michael S

[Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h

2018-03-27 Thread Tiwei Bie
This macro isn't used by any VFIO code. And its name is too generic. The vfio-common.h (in include/hw/vfio) can be included by other modules in QEMU. It can introduce conflicts. Signed-off-by: Tiwei Bie --- include/hw/vfio/vfio-common.h | 9 - 1 file changed, 9 deletions(-) diff --git a