Re: [Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-09 Thread Alex Williamson
On Mon, 9 Jul 2018 09:04:47 +0200 Cédric Le Goater wrote: > On 07/06/2018 07:16 PM, Alex Williamson wrote: > > On Fri, 6 Jul 2018 18:36:14 +0200 > > Cédric Le Goater wrote: > > > >> PCI devices needing a ROM allocate an optional MemoryRegion with > >> pci_add_option_rom(). pci_del_option_rom

Re: [Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-09 Thread Cédric Le Goater
On 07/06/2018 07:16 PM, Alex Williamson wrote: > On Fri, 6 Jul 2018 18:36:14 +0200 > Cédric Le Goater wrote: > >> PCI devices needing a ROM allocate an optional MemoryRegion with >> pci_add_option_rom(). pci_del_option_rom() does the cleanup when the >> device is destroyed. The only action taken

Re: [Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-06 Thread Michael S. Tsirkin
On Fri, Jul 06, 2018 at 06:36:14PM +0200, Cédric Le Goater wrote: > PCI devices needing a ROM allocate an optional MemoryRegion with > pci_add_option_rom(). pci_del_option_rom() does the cleanup when the > device is destroyed. The only action taken by this routine is to call > vmstate_unregister_ra

Re: [Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-06 Thread Alex Williamson
On Fri, 6 Jul 2018 18:36:14 +0200 Cédric Le Goater wrote: > PCI devices needing a ROM allocate an optional MemoryRegion with > pci_add_option_rom(). pci_del_option_rom() does the cleanup when the > device is destroyed. The only action taken by this routine is to call > vmstate_unregister_ram() w

[Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-06 Thread Cédric Le Goater
PCI devices needing a ROM allocate an optional MemoryRegion with pci_add_option_rom(). pci_del_option_rom() does the cleanup when the device is destroyed. The only action taken by this routine is to call vmstate_unregister_ram() which clears the id string of the optional ROM RAMBlock and now, also