Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Philippe Mathieu-Daudé
On 12/7/18 7:16 PM, Thomas Huth wrote: > On 2018-12-07 17:14, Philippe Mathieu-Daudé wrote: >> This NULL check was required while introduced in 680d16dcb79f. >> Later refactor added a NULL check in error_setv(), so this check >> is now redundant. >> >> Signed-off-by: Philippe Mathieu-Daudé >> ---

Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Thomas Huth
On 2018-12-07 17:14, Philippe Mathieu-Daudé wrote: > This NULL check was required while introduced in 680d16dcb79f. > Later refactor added a NULL check in error_setv(), so this check > is now redundant. > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/error.c | 4 > 1 file changed, 4

Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > This NULL check was required while introduced in 680d16dcb79f. > Later refactor added a NULL check in error_setv(), so this check > is now redundant. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Daniel P . Berrangé
On Fri, Dec 07, 2018 at 05:14:47PM +0100, Philippe Mathieu-Daudé wrote: > This NULL check was required while introduced in 680d16dcb79f. > Later refactor added a NULL check in error_setv(), so this check > is now redundant. > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/error.c | 4

[Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Philippe Mathieu-Daudé
This NULL check was required while introduced in 680d16dcb79f. Later refactor added a NULL check in error_setv(), so this check is now redundant. Signed-off-by: Philippe Mathieu-Daudé --- util/error.c | 4 1 file changed, 4 deletions(-) diff --git a/util/error.c b/util/error.c index b5ccbd