Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-02 Thread Eric Blake
On 03/01/2018 10:20 AM, Alex Williamson wrote: On Thu, 1 Mar 2018 10:08:06 +0300 Julia Suvorova via Qemu-devel wrote: basename(3) and dirname(3) modify their argument and may return pointers to statically allocated memory which may be overwritten by subsequent calls. g_path_get_basename and g

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-02 Thread Paolo Bonzini
On 01/03/2018 17:20, Alex Williamson wrote: >> basename(3) and dirname(3) modify their argument and may return >> pointers to statically allocated memory which may be overwritten by >> subsequent calls. >> g_path_get_basename and g_path_get_dirname have no such issues, and >> therefore more prefera

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Alex Williamson
On Thu, 1 Mar 2018 10:08:06 +0300 Julia Suvorova via Qemu-devel wrote: > basename(3) and dirname(3) modify their argument and may return > pointers to statically allocated memory which may be overwritten by > subsequent calls. > g_path_get_basename and g_path_get_dirname have no such issues, and

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Julia Suvorova via Qemu-devel
On 01.03.2018 14:21, Paolo Bonzini wrote: > On 01/03/2018 11:59, Cornelia Huck wrote: Signed-off-by: Julia Suvorova >>> What about adding a warning for basename()/dirname() usage in >>> scripts/checkpatch.pl ? >> +1 to that. >> > > Good idea indeed. Julia, would you like to send a

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Julia Suvorova via Qemu-devel
On 01.03.2018 13:59, Cornelia Huck wrote: > On Thu, 1 Mar 2018 10:47:42 +0100 > Marc-André Lureau wrote: > >> Hi >> >> On Thu, Mar 1, 2018 at 8:08 AM, Julia Suvorova via Qemu-devel >> wrote: >>> basename(3) and dirname(3) modify their argument and may return >>> pointers to statically allocate

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 11:59, Cornelia Huck wrote: >>> >>> Signed-off-by: Julia Suvorova >> What about adding a warning for basename()/dirname() usage in >> scripts/checkpatch.pl ? > +1 to that. > Good idea indeed. Julia, would you like to send a second patch that adds the warning? There are already

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 08:08, Julia Suvorova wrote: > +static void free_progname(void) > +{ > +g_free(progname); > +} > + > static void GCC_FMT_ATTR(2, 3) readline_printf_func(void *opaque, > const char *fmt, ...) > { > @@ -504,7 +509,8 @@ int main(

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Cornelia Huck
On Thu, 1 Mar 2018 10:47:42 +0100 Marc-André Lureau wrote: > Hi > > On Thu, Mar 1, 2018 at 8:08 AM, Julia Suvorova via Qemu-devel > wrote: > > basename(3) and dirname(3) modify their argument and may return > > pointers to statically allocated memory which may be overwritten by > > subsequent c

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Marc-André Lureau
Hi On Thu, Mar 1, 2018 at 8:08 AM, Julia Suvorova via Qemu-devel wrote: > basename(3) and dirname(3) modify their argument and may return > pointers to statically allocated memory which may be overwritten by > subsequent calls. > g_path_get_basename and g_path_get_dirname have no such issues, and

[Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-02-28 Thread Julia Suvorova via Qemu-devel
basename(3) and dirname(3) modify their argument and may return pointers to statically allocated memory which may be overwritten by subsequent calls. g_path_get_basename and g_path_get_dirname have no such issues, and therefore more preferable. Signed-off-by: Julia Suvorova --- fsdev/virtfs-prox