Re: [Qemu-devel] [PATCH] usb-storage: Fix how legacy init handles option ID clash

2014-09-14 Thread Gerd Hoffmann
On Fr, 2014-09-12 at 21:24 +0200, Markus Armbruster wrote: > usb_msd_init() calls qemu_opts_create() with a made-up ID and false > fail_if_exists. If the ID already exists, it happily messes up those > options, then fails drive_new(), because the BlockDriverState with > that ID already exists, to

[Qemu-devel] [PATCH] usb-storage: Fix how legacy init handles option ID clash

2014-09-12 Thread Markus Armbruster
usb_msd_init() calls qemu_opts_create() with a made-up ID and false fail_if_exists. If the ID already exists, it happily messes up those options, then fails drive_new(), because the BlockDriverState with that ID already exists, too. Reproducer: -drive if=none,id=usb0,format=raw -usbdevice disk:tm