Re: [Qemu-devel] [PATCH] usb-mtp: replace the homebrew write with qemu_write_full

2019-01-24 Thread Bandan Das
Gerd Hoffmann writes: > On Tue, Jan 22, 2019 at 07:41:16AM -0500, Bandan Das wrote: >> >> qemu_write_full takes care of partial blocking writes, >> as in cases of larger file sizes >> >> Suggested-by: Peter Maydell >> Signed-off-by: Bandan > > Hmm, doesn't apply, and git fails to do a 3way me

Re: [Qemu-devel] [PATCH] usb-mtp: replace the homebrew write with qemu_write_full

2019-01-24 Thread Gerd Hoffmann
On Thu, Jan 24, 2019 at 03:19:03AM -0500, Bandan Das wrote: > Gerd Hoffmann writes: > > > On Tue, Jan 22, 2019 at 07:41:16AM -0500, Bandan Das wrote: > >> > >> qemu_write_full takes care of partial blocking writes, > >> as in cases of larger file sizes > >> > >> Suggested-by: Peter Maydell > >

Re: [Qemu-devel] [PATCH] usb-mtp: replace the homebrew write with qemu_write_full

2019-01-24 Thread Gerd Hoffmann
On Tue, Jan 22, 2019 at 07:41:16AM -0500, Bandan Das wrote: > > qemu_write_full takes care of partial blocking writes, > as in cases of larger file sizes > > Suggested-by: Peter Maydell > Signed-off-by: Bandan Hmm, doesn't apply, and git fails to do a 3way merge too due to unknown sha1. cheer

[Qemu-devel] [PATCH] usb-mtp: replace the homebrew write with qemu_write_full

2019-01-22 Thread Bandan Das
qemu_write_full takes care of partial blocking writes, as in cases of larger file sizes Suggested-by: Peter Maydell Signed-off-by: Bandan --- hw/usb/dev-mtp.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 31fa8358