Re: [Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt

2012-05-11 Thread Gerd Hoffmann
On 05/08/12 14:06, Gerd Hoffmann wrote: > Most important here is to update our internal endpoint state so we know > the endpoint isn't in halted state any more. Without this usb-host > tries to clear halt again with the next data transfer submitted. Doing > this twice is (a) not correct and (b) c

Re: [Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt

2012-05-09 Thread Erik Rull
Looks VERY good, ACK! The DVD drive works now! On May 8, 2012 at 2:06 PM Gerd Hoffmann wrote: > Most important here is to update our internal endpoint state so we know > the endpoint isn't in halted state any more. Without this usb-host > tries to clear halt again with the next data transfer

Re: [Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt

2012-05-08 Thread Hans de Goede
Looks good, ACK. On 05/08/2012 02:06 PM, Gerd Hoffmann wrote: Most important here is to update our internal endpoint state so we know the endpoint isn't in halted state any more. Without this usb-host tries to clear halt again with the next data transfer submitted. Doing this twice is (a) not

[Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt

2012-05-08 Thread Gerd Hoffmann
Most important here is to update our internal endpoint state so we know the endpoint isn't in halted state any more. Without this usb-host tries to clear halt again with the next data transfer submitted. Doing this twice is (a) not correct and (b) confuses some usb devices, rendering them non-fun