Re: [Qemu-devel] [PATCH] usb-ehci: Ensure frindex writes leave a valid frindex value

2012-04-19 Thread Gerd Hoffmann
On 04/03/12 14:21, Hans de Goede wrote: > frindex is a 14 bits counter, so bits 31-14 should always be 0, and > after the commit titled "usb-ehci: frindex always is a 14 bits counter" > we rely on frindex always being a multiple of 8. I've not seen this in > practice, but theoretically a guest can

Re: [Qemu-devel] [PATCH] usb-ehci: Ensure frindex writes leave a valid frindex value

2012-04-03 Thread Alon Levy
On Tue, Apr 03, 2012 at 04:16:02PM +0300, Alon Levy wrote: > On Tue, Apr 03, 2012 at 02:21:47PM +0200, Hans de Goede wrote: > > frindex is a 14 bits counter, so bits 31-14 should always be 0, and > > after the commit titled "usb-ehci: frindex always is a 14 bits counter" > > we rely on frindex alwa

Re: [Qemu-devel] [PATCH] usb-ehci: Ensure frindex writes leave a valid frindex value

2012-04-03 Thread Alon Levy
On Tue, Apr 03, 2012 at 02:21:47PM +0200, Hans de Goede wrote: > frindex is a 14 bits counter, so bits 31-14 should always be 0, and > after the commit titled "usb-ehci: frindex always is a 14 bits counter" > we rely on frindex always being a multiple of 8. I've not seen this in > practice, but the

[Qemu-devel] [PATCH] usb-ehci: Ensure frindex writes leave a valid frindex value

2012-04-03 Thread Hans de Goede
frindex is a 14 bits counter, so bits 31-14 should always be 0, and after the commit titled "usb-ehci: frindex always is a 14 bits counter" we rely on frindex always being a multiple of 8. I've not seen this in practice, but theoretically a guest can write a value >= 0x4000 or a value which is not