Re: [Qemu-devel] [PATCH] usb-bus: fix no params

2010-03-29 Thread TeLeMan
On Mon, Mar 29, 2010 at 20:16, Kevin Wolf wrote: > Am 27.03.2010 13:47, schrieb Aurelien Jarno: >> On Fri, Mar 19, 2010 at 12:59:24PM +0800, TeLeMan wrote: >>> The "params" is never NULL and the usb hid devices have no params. >> >> This looks plainly wrong. With your patch, usb devices which don'

Re: [Qemu-devel] [PATCH] usb-bus: fix no params

2010-03-29 Thread Kevin Wolf
Am 27.03.2010 13:47, schrieb Aurelien Jarno: > On Fri, Mar 19, 2010 at 12:59:24PM +0800, TeLeMan wrote: >> The "params" is never NULL and the usb hid devices have no params. > > This looks plainly wrong. With your patch, usb devices which don't > accept parameters, will accept and ignore them. >

Re: [Qemu-devel] [PATCH] usb-bus: fix no params

2010-03-27 Thread Aurelien Jarno
On Fri, Mar 19, 2010 at 12:59:24PM +0800, TeLeMan wrote: > The "params" is never NULL and the usb hid devices have no params. This looks plainly wrong. With your patch, usb devices which don't accept parameters, will accept and ignore them. What are you trying to fix here? > Signed-off-by: TeLeM

[Qemu-devel] [PATCH] usb-bus: fix no params

2010-03-18 Thread TeLeMan
The "params" is never NULL and the usb hid devices have no params. Signed-off-by: TeLeMan --- hw/usb-bus.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index ce8a694..f3f1ed6 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -299,10 +299,6