Re: [Qemu-devel] [PATCH] usb: assign unique serial numbers to hid devices

2018-09-14 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > > > +[STR_SERIAL_MOUSE] = "89126", > > > +[STR_SERIAL_TABLET]= "28754", > > > +[STR_SERIAL_KEYBOARD] = "68284", > > > > Is there any significance to the magical numbers? > > No, other than that the three device types should have di

Re: [Qemu-devel] [PATCH] usb: assign unique serial numbers to hid devices

2018-09-14 Thread Gerd Hoffmann
> > +[STR_SERIAL_MOUSE] = "89126", > > +[STR_SERIAL_TABLET]= "28754", > > +[STR_SERIAL_KEYBOARD] = "68284", > > Is there any significance to the magical numbers? No, other than that the three device types should have different ones. > Will this change trigger a serial number

Re: [Qemu-devel] [PATCH] usb: assign unique serial numbers to hid devices

2018-09-14 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Windows guests have trouble dealing with usb devices having identical > serial numbers. So, assign unique serial numbers to usb hid devices. > All other usb devices have this already. > > Signed-off-by: Gerd Hoffmann OK, so that's part of https://bug

[Qemu-devel] [PATCH] usb: assign unique serial numbers to hid devices

2018-09-14 Thread Gerd Hoffmann
Windows guests have trouble dealing with usb devices having identical serial numbers. So, assign unique serial numbers to usb hid devices. All other usb devices have this already. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hid.c | 24 +--- 1 file changed, 13 insertions(+),