Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path

2012-03-28 Thread Michael Roth
On Thu, Mar 22, 2012 at 04:12:12PM +0100, Andreas Färber wrote: > Am 22.03.2012 15:37, schrieb Gerd Hoffmann: > >>> +.driver = "USB", > >>> +.property = "full-path", > >>> +.value= "no", > >> > >> This touches on our "favorite" bit/bool topic again. While I

Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path

2012-03-22 Thread Andreas Färber
Am 22.03.2012 15:37, schrieb Gerd Hoffmann: >>> +.driver = "USB", >>> +.property = "full-path", >>> +.value= "no", >> >> This touches on our "favorite" bit/bool topic again. While I agree that >> "no" makes sense for a property of that name, the current cod

Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path

2012-03-22 Thread Gerd Hoffmann
Hi, >> +.driver = "USB", >> +.property = "full-path", >> +.value= "no", > > This touches on our "favorite" bit/bool topic again. While I agree that > "no" makes sense for a property of that name, the current code still > expects "on" and "off". In parti

Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path

2012-03-22 Thread Andreas Färber
Am 22.03.2012 13:07, schrieb Gerd Hoffmann: > ... to make vmstate id string truely unique with multiple host > controllers, i.e. move from "1/usb-ptr" to ":00:01.3/1/usb-ptr" > (usb tabled connected to piix3 uhci). > > This obviously breaks migration. To handle this the usb bus > property "fu

Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path

2012-03-22 Thread Paolo Bonzini
Il 22/03/2012 13:07, Gerd Hoffmann ha scritto: > @@ -460,7 +462,21 @@ static void usb_bus_dev_print(Monitor *mon, DeviceState > *qdev, int indent) > static char *usb_get_dev_path(DeviceState *qdev) > { > USBDevice *dev = USB_DEVICE(qdev); > -return g_strdup(dev->port->path); > +Devi

[Qemu-devel] [PATCH] usb/vmstate: add parent dev path

2012-03-22 Thread Gerd Hoffmann
... to make vmstate id string truely unique with multiple host controllers, i.e. move from "1/usb-ptr" to ":00:01.3/1/usb-ptr" (usb tabled connected to piix3 uhci). This obviously breaks migration. To handle this the usb bus property "full-path" is added. When setting this to false old behav