Re: [Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros

On Thu, 16 May 2013 13:19:47 +0800 Amos Kong wrote: > It's clearer to use defined macros than magic numbers. > > Signed-off-by: Amos Kong Applied to the qmp branch, thanks. > --- > ui/input.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/ui/input.c b

Re: [Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros

On 05/16/2013 01:19 PM, Amos Kong wrote: It's clearer to use defined macros than magic numbers. Signed-off-by: Amos Kong --- ui/input.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ui/input.c b/ui/input.c index 8ca1a03..92c44ca 100644 --- a/ui/input.c +++

[Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros

It's clearer to use defined macros than magic numbers. Signed-off-by: Amos Kong --- ui/input.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ui/input.c b/ui/input.c index 8ca1a03..92c44ca 100644 --- a/ui/input.c +++ b/ui/input.c @@ -28,6 +28,7 @@ #include "qa