Re: [Qemu-devel] [PATCH] ui/gtk: fix crash at startup when no console is available

2017-01-03 Thread Stefan Hajnoczi
On Sun, Jan 01, 2017 at 10:39:45AM +0100, Hervé Poussineau wrote: > This patch fixes a segfault at QEMU startup, introduced in > a08156321ab9a7d2fed9ee77dbfeea2a61ffd153. > gd_vc_find_current() return NULL, which is dereferenced without checking it. > > While at it, disable the whole 'View' menu

[Qemu-devel] [PATCH] ui/gtk: fix crash at startup when no console is available

2017-01-01 Thread Hervé Poussineau
This patch fixes a segfault at QEMU startup, introduced in a08156321ab9a7d2fed9ee77dbfeea2a61ffd153. gd_vc_find_current() return NULL, which is dereferenced without checking it. While at it, disable the whole 'View' menu if no console exists. Reproducer: qemu-system-i386 -M none -nodefaults Sig