Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-11-03 Thread Peter Maydell
On 3 November 2014 14:27, Michael Tokarev wrote: > I usually reluctant to add these unused attributes and shut up other > warnings by force, because with time this cruft does not help, and > more and more code becomes "forgotten". If it is not needed for > windows, why add it? You could equally

Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-11-03 Thread Michael Tokarev
03.11.2014 15:25, Peter Maydell wrote: > On 3 November 2014 09:16, Michael Tokarev wrote: >> 03.11.2014 11:18, SeokYeon Hwang wrote: --- a/translate-all.c +++ b/translate-all.c @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr) } #ifdef _

Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-11-03 Thread Peter Maydell
On 3 November 2014 09:16, Michael Tokarev wrote: > 03.11.2014 11:18, SeokYeon Hwang wrote: >>> --- a/translate-all.c >>> +++ b/translate-all.c >>> @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t >>> retaddr) } >>> >>> #ifdef _WIN32 >>> -static inline void map_exec(void *add

Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-11-03 Thread Michael Tokarev
03.11.2014 11:18, SeokYeon Hwang wrote: >> -Original Message- >> From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> Sent: Saturday, November 01, 2014 3:30 AM >> To: SeokYeon Hwang >> Cc: QEMU Developers >> Subject: Re: [Qemu-devel] [PATCH]

Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-11-03 Thread SeokYeon Hwang
I posted a new patch which your suggestion is applied. Thanks. > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, November 01, 2014 3:30 AM > To: SeokYeon Hwang > Cc: QEMU Developers > Subject: Re: [Qemu-devel] [PATCH] tran

Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-10-31 Thread Peter Maydell
On 31 October 2014 04:59, SeokYeon Hwang wrote: > Moved map_exec() and wrapped it in #ifdef to avoid "-Wunused-function" on > clang 3.4 or later. > > Signed-off-by: SeokYeon Hwang I had this kind of on my todo list too, but I didn't much like the nested ifdefs which are really only because of w

[Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-10-31 Thread SeokYeon Hwang
Moved map_exec() and wrapped it in #ifdef to avoid "-Wunused-function" on clang 3.4 or later. Signed-off-by: SeokYeon Hwang --- translate-all.c | 52 +++- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/translate-all.c b/translate-