Re: [Qemu-devel] [PATCH] translate-all: Enable locking debug in a debug build

2016-11-16 Thread Pranith Kumar
On Wed, Nov 16, 2016 at 10:57 AM, Alex Bennée wrote: > > Pranith Kumar writes: > >> Unconditionally enable locking checks in debug builds so that we get >> wider testing. Using tcg_debug_assert() allows us to remove >> DEBUG_LOCKING define. > > Interesting. The other option would be to add a debu

Re: [Qemu-devel] [PATCH] translate-all: Enable locking debug in a debug build

2016-11-16 Thread Richard Henderson
On 11/16/2016 04:57 PM, Alex Bennée wrote: > +#define assert_tb_locked() do { \ > +tcg_debug_assert(have_tb_lock); \ > +} while (0) > + > +#define assert_tb_unlocked() do { \ > +tcg_debug_assert(!have_tb_lock);\ > +} while (0) > + I'm not sur

Re: [Qemu-devel] [PATCH] translate-all: Enable locking debug in a debug build

2016-11-16 Thread Alex Bennée
Pranith Kumar writes: > Unconditionally enable locking checks in debug builds so that we get > wider testing. Using tcg_debug_assert() allows us to remove > DEBUG_LOCKING define. Interesting. The other option would be to add a debug build to .travis.yml that define this (and others) with -DFOO_

[Qemu-devel] [PATCH] translate-all: Enable locking debug in a debug build

2016-11-16 Thread Pranith Kumar
Unconditionally enable locking checks in debug builds so that we get wider testing. Using tcg_debug_assert() allows us to remove DEBUG_LOCKING define. Signed-off-by: Pranith Kumar --- translate-all.c | 50 +- 1 file changed, 17 insertions(+), 33 de