Re: [Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-25 Thread Michael Roth
Quoting Stefan Hajnoczi (2017-09-19 10:50:25) > Clear tg->any_timer_armed[] when throttling timers are destroy during > AioContext attach/detach. Failure to do so causes throttling to hang > because we believe the timer is already scheduled! > > The following was broken at least since QEMU 2.10.0

Re: [Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-20 Thread Alberto Garcia
On Tue 19 Sep 2017 05:50:25 PM CEST, Stefan Hajnoczi wrote: > Clear tg->any_timer_armed[] when throttling timers are destroy during > AioContext attach/detach. Failure to do so causes throttling to hang > because we believe the timer is already scheduled! > > The following was broken at least sinc

Re: [Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-19 Thread Stefan Hajnoczi
On Tue, Sep 19, 2017 at 11:07:53AM -0500, Eric Blake wrote: > On 09/19/2017 10:50 AM, Stefan Hajnoczi wrote: > > Clear tg->any_timer_armed[] when throttling timers are destroy during > > s/destroy/destroyed/ All your base are belong to us!

Re: [Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-19 Thread Eric Blake
On 09/19/2017 10:50 AM, Stefan Hajnoczi wrote: > Clear tg->any_timer_armed[] when throttling timers are destroy during s/destroy/destroyed/ > AioContext attach/detach. Failure to do so causes throttling to hang > because we believe the timer is already scheduled! > > The following was broken at

[Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-19 Thread Stefan Hajnoczi
Clear tg->any_timer_armed[] when throttling timers are destroy during AioContext attach/detach. Failure to do so causes throttling to hang because we believe the timer is already scheduled! The following was broken at least since QEMU 2.10.0 with -drive iops=100: $ dd if=/dev/zero of=/dev/vdb