Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-17 Thread Michael S. Tsirkin
On Mon, Jul 17, 2017 at 09:28:15AM +0200, Laurent Vivier wrote: > On 14/07/2017 16:37, Michael S. Tsirkin wrote: > > On Fri, Jul 14, 2017 at 02:20:33AM -0400, Paolo Bonzini wrote: > >> > >>> NACK. > >>> > >>> It's not that simple. If you do it like this, you then suddenly get > >>> these ugly '"kvm

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-17 Thread Thomas Huth
On 14.07.2017 16:45, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 07:59:54AM +0200, Thomas Huth wrote: >> On 13.07.2017 19:00, Paolo Bonzini wrote: >>> On 13/07/2017 18:47, Michael S. Tsirkin wrote: Speed up tests on host systems with kvm support. [...] diff --git a/tests/vmgenid-t

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-17 Thread Laurent Vivier
On 14/07/2017 16:37, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 02:20:33AM -0400, Paolo Bonzini wrote: >> >>> NACK. >>> >>> It's not that simple. If you do it like this, you then suddenly get >>> these ugly '"kvm" accelerator not found' messages during "make check" >>> which we really shou

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 07:59:54AM +0200, Thomas Huth wrote: > On 13.07.2017 19:00, Paolo Bonzini wrote: > > On 13/07/2017 18:47, Michael S. Tsirkin wrote: > >> Speed up tests on host systems with kvm support. > >> > >> Cc: Paolo Bonzini > >> Cc: Thomas Huth > >> Cc: Laurent Vivier > >> Signed-o

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 02:20:33AM -0400, Paolo Bonzini wrote: > > > NACK. > > > > It's not that simple. If you do it like this, you then suddenly get > > these ugly '"kvm" accelerator not found' messages during "make check" > > which we really should avoid. > > You're right, I thought these wer

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-13 Thread Paolo Bonzini
> NACK. > > It's not that simple. If you do it like this, you then suddenly get > these ugly '"kvm" accelerator not found' messages during "make check" > which we really should avoid. You're right, I thought these were shut up before with Laurent's patch. I think we should print a single message

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-13 Thread Thomas Huth
On 13.07.2017 19:00, Paolo Bonzini wrote: > On 13/07/2017 18:47, Michael S. Tsirkin wrote: >> Speed up tests on host systems with kvm support. >> >> Cc: Paolo Bonzini >> Cc: Thomas Huth >> Cc: Laurent Vivier >> Signed-off-by: Michael S. Tsirkin >> --- >> >> This is on top of my previous patch f

[Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-13 Thread Michael S. Tsirkin
Speed up tests on host systems with kvm support. Cc: Paolo Bonzini Cc: Thomas Huth Cc: Laurent Vivier Signed-off-by: Michael S. Tsirkin --- This is on top of my previous patch fixing vmgenid. PPC PXE test is reported to be especially slow - does anyone care to try it and measure whether this

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-13 Thread Paolo Bonzini
On 13/07/2017 18:47, Michael S. Tsirkin wrote: > Speed up tests on host systems with kvm support. > > Cc: Paolo Bonzini > Cc: Thomas Huth > Cc: Laurent Vivier > Signed-off-by: Michael S. Tsirkin > --- > > This is on top of my previous patch fixing vmgenid. > > PPC PXE test is reported to be

[Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-13 Thread Michael S. Tsirkin
Speed up tests on host systems with kvm by using it. Signed-off-by: Michael S. Tsirkin --- tests/pxe-test.c | 2 +- tests/vmgenid-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/pxe-test.c b/tests/pxe-test.c index 34282d3..cf6e225 100644 --- a/tests/pxe-te