Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-19 Thread Richard W.M. Jones
On Fri, May 17, 2013 at 11:07:38AM +0100, Daniel P. Berrange wrote: > On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: > > If you want punishment, why not go for extra punishment? > > > > MALLOC_PERTURB_=$(($RANDOM % 255 + 1)) > > That could lead to non-reproducable failures th

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Lucas Meneghel Rodrigues
On 17/05/13 07:58 AM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: Stefan Hajnoczi writes: glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable d

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Lucas Meneghel Rodrigues
On 17/05/13 08:15 AM, Stefan Hajnoczi wrote: On Fri, May 17, 2013 at 11:54 AM, Markus Armbruster wrote: Stefan Hajnoczi writes: glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe me

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Lucas Meneghel Rodrigues
On 17/05/13 07:07 AM, Daniel P. Berrange wrote: If you want punishment, why not go for extra punishment? MALLOC_PERTURB_=$(($RANDOM % 255 + 1)) That could lead to non-reproducable failures though. I think it is better to use a fixed value so that you're more likely to be able to reproduce the

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 12:07 PM, Daniel P. Berrange wrote: > Rather than setting MALLOC_PERTURB_=1 unconditionally in the Makefile > though, it ought to honour any existing MALLOC_PERTURB_ env variable > the user has set. That could let automated test harness run repeatedly > with random MALLOC_P

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 11:54 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment >> variable is set. The value of the environment variable determines the >> bit pattern used to wipe memory. For more information, see >> h

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment >> > variable is set. The value of the environment variable determines the >> > bit pattern use

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Daniel P. Berrange
On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > > variable is set. The value of the environment variable determines the > > bit pattern used to wipe memory. For more informatio

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > variable is set. The value of the environment variable determines the > bit pattern used to wipe memory. For more information, see > http://udrepper.livejournal.com/11429.html. > > Set MALLOC_PERTURB_

[Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Stefan Hajnoczi
glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe memory. For more information, see http://udrepper.livejournal.com/11429.html. Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note w