Re: [Qemu-devel] [PATCH] tests: minor cleanups in usb-hcd-uhci-test

2016-10-08 Thread David Gibson
On Fri, Oct 07, 2016 at 10:40:45AM +0200, Gerd Hoffmann wrote: > On Fr, 2016-10-07 at 10:49 +1100, David Gibson wrote: > > On Thu, Oct 06, 2016 at 04:50:48PM +0200, Laurent Vivier wrote: > > > Two minor cleanups: > > > - exit gracefully in case on unsupported target, > > > - put machine command lin

Re: [Qemu-devel] [PATCH] tests: minor cleanups in usb-hcd-uhci-test

2016-10-07 Thread Gerd Hoffmann
On Fr, 2016-10-07 at 10:49 +1100, David Gibson wrote: > On Thu, Oct 06, 2016 at 04:50:48PM +0200, Laurent Vivier wrote: > > Two minor cleanups: > > - exit gracefully in case on unsupported target, > > - put machine command line in a constant to avoid > > to duplicate it. > > > > Signed-off-by: L

Re: [Qemu-devel] [PATCH] tests: minor cleanups in usb-hcd-uhci-test

2016-10-06 Thread David Gibson
On Thu, Oct 06, 2016 at 04:50:48PM +0200, Laurent Vivier wrote: > Two minor cleanups: > - exit gracefully in case on unsupported target, > - put machine command line in a constant to avoid > to duplicate it. > > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson I'm not sure if I should

[Qemu-devel] [PATCH] tests: minor cleanups in usb-hcd-uhci-test

2016-10-06 Thread Laurent Vivier
Two minor cleanups: - exit gracefully in case on unsupported target, - put machine command line in a constant to avoid to duplicate it. Signed-off-by: Laurent Vivier --- tests/usb-hcd-uhci-test.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/usb-hcd-