Re: [Qemu-devel] [PATCH] tests: consolidate common includes under libqtest.h

2015-05-05 Thread Paolo Bonzini
On 01/05/2015 00:21, Emilio G. Cota wrote: > Something like the appended? > > Cheers, > > Emilio Pretty good, but I wouldn't use qemu-common.h, at least not until all the function and macro declarations are moved to separate headers (some of them may indeed move to osdep.h, in fact

[Qemu-devel] [PATCH] tests: consolidate common includes under libqtest.h

2015-04-30 Thread Emilio G. Cota
On Thu, Apr 30, 2015 at 23:14:06 +0300, Michael Tokarev wrote: > 30.04.2015 22:16, Emilio G. Cota wrote: > > ARRAY_SIZE is defined in osdep.h so having an unconditional > > definition here is fragile. > > Fragile in what sense? Nothing in that file includes osdep.h. Fragile in that future, unrela