Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Peter Crosthwaite
On Sat, Dec 21, 2013 at 12:08 AM, Igor Mammedov wrote: > On Fri, 20 Dec 2013 14:58:07 +0100 > Andreas Färber wrote: > >> Am 20.12.2013 14:26, schrieb Igor Mammedov: >> > Add basic regression testing for QOM Interface usage. >> > >> > Signed-off-by: Igor Mammedov >> > --- >> > v2: >> > - Peter C

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Paolo Bonzini
Il 20/12/2013 16:14, Igor Mammedov ha scritto: > Andreas, > > test shows that commit: > > "qom: Do not register interface "types" in the type table " > https://github.com/afaerber/qemu-cpu/commit/7f00136ff5534ee651f4f10475170b8db18e5c03 > > regresses QOM Interface in case where interface is impl

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Paolo Bonzini
Il 20/12/2013 14:26, Igor Mammedov ha scritto: > index 379cdd9..89f8eff 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -52,6 +52,8 @@ check-unit-y += tests/test-int128$(EXESUF) > gcov-files-test-int128-y = > check-unit-y += tests/test-bitops$(EXESUF) > check-unit-y += tests/test-qdev-

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
On Fri, 20 Dec 2013 14:26:11 +0100 Igor Mammedov wrote: Andreas, test shows that commit: "qom: Do not register interface "types" in the type table " https://github.com/afaerber/qemu-cpu/commit/7f00136ff5534ee651f4f10475170b8db18e5c03 regresses QOM Interface in case where interface is implement

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
On Fri, 20 Dec 2013 14:58:07 +0100 Andreas Färber wrote: > Am 20.12.2013 14:26, schrieb Igor Mammedov: > > Add basic regression testing for QOM Interface usage. > > > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - Peter Crosthwaite > >* s/Parent/parent_obj/ > >* s/parent/parent_

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Andreas Färber
Am 20.12.2013 14:26, schrieb Igor Mammedov: > Add basic regression testing for QOM Interface usage. > > Signed-off-by: Igor Mammedov > --- > v2: > - Peter Crosthwaite >* s/Parent/parent_obj/ >* s/parent/parent_class/ > - Peter Maydell >* s/interfacei/interface/ >* tests/Makefi

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Peter Maydell
On 20 December 2013 13:26, Igor Mammedov wrote: > Add basic regression testing for QOM Interface usage. > > +/* > + * OQM interface test. Still says "OQM" not "QOM"... thanks -- PMM

[Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
Add basic regression testing for QOM Interface usage. Signed-off-by: Igor Mammedov --- v2: - Peter Crosthwaite * s/Parent/parent_obj/ * s/parent/parent_class/ - Peter Maydell * s/interfacei/interface/ * tests/Makefile split too long line - Andreas Färber * consolidate QOM cor