Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-24 Thread Blue Swirl
Thanks, applied. On Tue, Jun 19, 2012 at 2:31 AM, Scott Wood wrote: > If tci_out_label is called in the context of tcg_gen_code_search_pc, we > could be overwriting an already patched relocation with zero -- and not > repatch it because the set_label is past search_pc, causing a QEMU crash > when

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-20 Thread Stefan Weil
Am 19.06.2012 20:02, schrieb Blue Swirl: On Tue, Jun 19, 2012 at 5:53 AM, Stefan Weil wrote: Am 19.06.2012 04:31, schrieb Scott Wood: If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it beca

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-19 Thread Peter Maydell
On 19 June 2012 22:52, Scott Wood wrote: > On 06/19/2012 12:53 AM, Stefan Weil wrote: >> I saw from git history that ppc once had the same bug. >> The sparc backend (and maybe others) might still have it. > > SPARC looks wrong; the others look OK as far as I can tell from a quick > glance, without

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-19 Thread Scott Wood
On 06/19/2012 12:53 AM, Stefan Weil wrote: > Am 19.06.2012 04:31, schrieb Scott Wood: >> If tci_out_label is called in the context of tcg_gen_code_search_pc, we >> could be overwriting an already patched relocation with zero -- and not >> repatch it because the set_label is past search_pc, causing

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 5:53 AM, Stefan Weil wrote: > Am 19.06.2012 04:31, schrieb Scott Wood: > >> If tci_out_label is called in the context of tcg_gen_code_search_pc, we >> could be overwriting an already patched relocation with zero -- and not >> repatch it because the set_label is past search_

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-18 Thread Stefan Weil
Am 19.06.2012 04:31, schrieb Scott Wood: If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it because the set_label is past search_pc, causing a QEMU crash when it tries to branch to a zero label

[Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-18 Thread Scott Wood
If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it because the set_label is past search_pc, causing a QEMU crash when it tries to branch to a zero label. Not writing anything to the relocation a