Re: [Qemu-devel] [PATCH] tci: Fix some unaligned memory accesses

2019-04-09 Thread Peter Maydell
On Tue, 9 Apr 2019 at 18:04, Stefan Weil wrote: > > On 09.04.19 08:58, Richard Henderson wrote: > > On 4/8/19 8:04 PM, Stefan Weil wrote: > >> static tcg_target_ulong tci_read_i(uint8_t **tb_ptr) > >> { > >> -tcg_target_ulong value = *(tcg_target_ulong *)(*tb_ptr); > >> +tcg_target_ulong

Re: [Qemu-devel] [PATCH] tci: Fix some unaligned memory accesses

2019-04-09 Thread Stefan Weil
On 09.04.19 08:58, Richard Henderson wrote: > On 4/8/19 8:04 PM, Stefan Weil wrote: >> static tcg_target_ulong tci_read_i(uint8_t **tb_ptr) >> { >> -tcg_target_ulong value = *(tcg_target_ulong *)(*tb_ptr); >> +tcg_target_ulong value; > > Ideally these would use the helpers from "qemu/bsw

Re: [Qemu-devel] [PATCH] tci: Fix some unaligned memory accesses

2019-04-08 Thread Richard Henderson
On 4/8/19 8:04 PM, Stefan Weil wrote: > static tcg_target_ulong tci_read_i(uint8_t **tb_ptr) > { > -tcg_target_ulong value = *(tcg_target_ulong *)(*tb_ptr); > +tcg_target_ulong value; Ideally these would use the helpers from "qemu/bswap.h", ldl_he_p(), etc. r~

[Qemu-devel] [PATCH] tci: Fix some unaligned memory accesses

2019-04-08 Thread Stefan Weil
Signed-off-by: Stefan Weil --- tcg/tci.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tcg/tci.c b/tcg/tci.c index 33edca1903..20b0715b6e 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -1,7 +1,7 @@ /* * Tiny Code Interpreter for QEMU * - * Copyright (c) 2