Re: [Qemu-devel] [PATCH] tci: Fix build regression

2016-04-04 Thread Peter Maydell
On 4 April 2016 at 21:40, Stefan Weil wrote: > Am 04.04.2016 um 20:06 schrieb Sergey Fedorov: >> On 04/04/16 20:50, Stefan Weil wrote: >>> -/* Defining NDEBUG disables assertions (which makes the code faster). */ >>> -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG) >>> -# define NDEBUG >>> +/*

Re: [Qemu-devel] [PATCH] tci: Fix build regression

2016-04-04 Thread Stefan Weil
Am 04.04.2016 um 20:06 schrieb Sergey Fedorov: > On 04/04/16 20:50, Stefan Weil wrote: >> -/* Defining NDEBUG disables assertions (which makes the code faster). */ >> -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG) >> -# define NDEBUG >> +/* Enable TCI assertions only when debugging TCG (and wi

Re: [Qemu-devel] [PATCH] tci: Fix build regression

2016-04-04 Thread Sergey Fedorov
On 04/04/16 20:50, Stefan Weil wrote: > -/* Defining NDEBUG disables assertions (which makes the code faster). */ > -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG) > -# define NDEBUG > +/* Enable TCI assertions only when debugging TCG (and without NDEBUG > defined). > + * Without assertions, t

[Qemu-devel] [PATCH] tci: Fix build regression

2016-04-04 Thread Stefan Weil
Commit d38ea87ac54af64ef611de434d07c12dc0399216 cleaned the include statements which resulted in a wrong order of assert.h and the definition of NDEBUG in tci.c. Normally NDEBUG modifies the definition of the assert macro, but here this definition comes too late which results in a failing build. T