Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-09 Thread Aurelien Jarno
On Mon, Sep 09, 2013 at 06:14:34PM +0200, Stefan Weil wrote: > Am 09.09.2013 16:53, schrieb Aurelien Jarno: > > On Wed, Sep 04, 2013 at 10:51:54PM +0200, Stefan Weil wrote: > >> Am 04.09.2013 22:49, schrieb Stefan Weil: > >>> It is used by qemu-ppc64 when running Debian's busybox-static. > >>> > >>

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-09 Thread Stefan Weil
Am 09.09.2013 16:53, schrieb Aurelien Jarno: > On Wed, Sep 04, 2013 at 10:51:54PM +0200, Stefan Weil wrote: >> Am 04.09.2013 22:49, schrieb Stefan Weil: >>> It is used by qemu-ppc64 when running Debian's busybox-static. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> >>> This patch is also useful f

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-09 Thread Aurelien Jarno
On Wed, Sep 04, 2013 at 10:51:54PM +0200, Stefan Weil wrote: > Am 04.09.2013 22:49, schrieb Stefan Weil: > > It is used by qemu-ppc64 when running Debian's busybox-static. > > > > Signed-off-by: Stefan Weil > > --- > > > > This patch is also useful for QEMU 1.6. > > ... so I should have added qem

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-05 Thread Richard Henderson
On 09/05/2013 01:17 PM, Stefan Weil wrote: > I added assertions for (t2 > 0) and (t2 < 64). They never raised an abort. > Are those cases possible? We already have similar code for 32 bit shifts, > and tcg/optimize.c also includes an implementation which is identical to > my rotl_i64, rotr_i64. It

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-05 Thread Stefan Weil
Am 05.09.2013 14:00, schrieb Jay Foad: >> diff --git a/tci.c b/tci.c >> index 18c888e..94b7851 100644 >> --- a/tci.c >> +++ b/tci.c >> @@ -952,8 +952,16 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t >> *tb_ptr) >> break; >> #if TCG_TARGET_HAS_rot_i64 >> case INDEX

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-05 Thread Jay Foad
> diff --git a/tci.c b/tci.c > index 18c888e..94b7851 100644 > --- a/tci.c > +++ b/tci.c > @@ -952,8 +952,16 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t > *tb_ptr) > break; > #if TCG_TARGET_HAS_rot_i64 > case INDEX_op_rotl_i64: > +t0 = *tb_ptr++; > +

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-04 Thread Richard Henderson
On 09/04/2013 01:49 PM, Stefan Weil wrote: > It is used by qemu-ppc64 when running Debian's busybox-static. > > Signed-off-by: Stefan Weil > --- > > This patch is also useful for QEMU 1.6. Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-04 Thread Stefan Weil
Am 04.09.2013 22:49, schrieb Stefan Weil: > It is used by qemu-ppc64 when running Debian's busybox-static. > > Signed-off-by: Stefan Weil > --- > > This patch is also useful for QEMU 1.6. ... so I should have added qemu-stable. Done now. > > tcg/tci/tcg-target.c |1 - > tci.c

[Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-04 Thread Stefan Weil
It is used by qemu-ppc64 when running Debian's busybox-static. Signed-off-by: Stefan Weil --- This patch is also useful for QEMU 1.6. tcg/tci/tcg-target.c |1 - tci.c| 10 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/tci/tcg-target.c b/tcg