On 29 June 2018 at 21:07, Philippe Mathieu-Daudé wrote:
> Fix the --disable-tcg breakage introduced by 8bca9a03ec60d:
>
> $ configure --disable-tcg
> [...]
> $ make -C i386-softmmu exec.o
> make: Entering directory 'i386-softmmu'
> CC exec.o
> In file included from s
Fix the --disable-tcg breakage introduced by 8bca9a03ec60d:
$ configure --disable-tcg
[...]
$ make -C i386-softmmu exec.o
make: Entering directory 'i386-softmmu'
CC exec.o
In file included from source/qemu/exec.c:62:0:
source/qemu/include/exec/ram_addr.h:96:6: er
On 22 June 2018 at 18:45, Emilio G. Cota wrote:
> Fix the --disable-tcg breakage introduced by tb_lock's removal by
> relying on the fact that tcg_enabled() is set to 0 at
> compile-time under --disable-tcg.
>
> While at it, add further asserts to fix builds that enable both
> --disable-tcg and --
On 06/22/2018 10:45 AM, Emilio G. Cota wrote:
> Fix the --disable-tcg breakage introduced by tb_lock's removal by
> relying on the fact that tcg_enabled() is set to 0 at
> compile-time under --disable-tcg.
>
> While at it, add further asserts to fix builds that enable both
> --disable-tcg and --en
Fix the --disable-tcg breakage introduced by tb_lock's removal by
relying on the fact that tcg_enabled() is set to 0 at
compile-time under --disable-tcg.
While at it, add further asserts to fix builds that enable both
--disable-tcg and --enable-debug, which were broken even before
tb_lock's remova
On Fri, Jun 22, 2018 at 17:24:33 +0100, Peter Maydell wrote:
> On 22 June 2018 at 17:16, Emilio G. Cota wrote:
> It's probably the --enable-debug that makes the difference:
> for instance cpu_reloading_memory_map() is referenced from
> tcg_commit(), which is only called from within an "if (tcg_ena
On 22 June 2018 at 17:24, Peter Maydell wrote:
> Possibly this has always been broken and wasn't a regression?
> If so I guess we should apply your patch and then fix this
> separately...
Yep, before your tb_lock changes on my system I can build
--disable-tcg, but not --disable-tcg --enable-debug
On 22 June 2018 at 17:16, Emilio G. Cota wrote:
> Tested to build x86_64-softmmu and i386-softmmu targets.
>
> Reported-by: Peter Maydell
> Signed-off-by: Emilio G. Cota
> ---
> accel/stubs/tcg-stub.c | 4
> exec.c | 4
> 2 files changed, 4 insertions(+), 4 deletions(-
Tested to build x86_64-softmmu and i386-softmmu targets.
Reported-by: Peter Maydell
Signed-off-by: Emilio G. Cota
---
accel/stubs/tcg-stub.c | 4
exec.c | 4
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
