Re: [Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16

2018-05-24 Thread Richard Henderson
On 05/24/2018 06:21 AM, Peter Maydell wrote: > Applied to target-arm.next, thanks. Is it worth marking this as > cc:stable? Probably, since we've marked most of the other f16 patches for stable. r~

Re: [Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16

2018-05-24 Thread Peter Maydell
On 22 May 2018 at 18:56, Richard Henderson wrote: > Depending on the host abi, float16, aka uint16_t, values are > passed and returned either zero-extended in the host register > or with garbage at the top of the host register. > > The tcg code generator has so far been assuming garbage, as that >

Re: [Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16

2018-05-24 Thread Laurent Desnogues
On Thu, May 24, 2018 at 2:28 PM, Peter Maydell wrote: > On 23 May 2018 at 06:10, Laurent Desnogues > wrote: >> Some AArch64 tests I had that previously failed on a x86-64 host now pass. >> >> Tested-by: Laurent Desnogues > > Thanks for the testing. > >> Perhaps the two occurrences of the follow

Re: [Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16

2018-05-24 Thread Peter Maydell
On 23 May 2018 at 06:10, Laurent Desnogues wrote: > Some AArch64 tests I had that previously failed on a x86-64 host now pass. > > Tested-by: Laurent Desnogues Thanks for the testing. > Perhaps the two occurrences of the following comment in > target/arm/translate-a64.c could be removed along w

Re: [Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16

2018-05-22 Thread Laurent Desnogues
Hello, On Tue, May 22, 2018 at 7:56 PM, Richard Henderson wrote: > Depending on the host abi, float16, aka uint16_t, values are > passed and returned either zero-extended in the host register > or with garbage at the top of the host register. > > The tcg code generator has so far been assuming ga

Re: [Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16

2018-05-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180522175629.24932-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16 === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] tcg: Fix helper function vs host abi for float16

2018-05-22 Thread Richard Henderson
Depending on the host abi, float16, aka uint16_t, values are passed and returned either zero-extended in the host register or with garbage at the top of the host register. The tcg code generator has so far been assuming garbage, as that matches the x86 abi, but this is incorrect for other host abi