Re: [Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

2015-01-10 Thread Richard Henderson
On 01/10/2015 01:15 PM, Bastian Koppelmann wrote: > Fair enough. Where would you recommend to put the documentation? I don't know. I don't know where would be most useful. Perhaps just expanded comments in the header? Comments might be best, as it'll be easiest to keep up to date as the code evo

Re: [Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

2015-01-10 Thread Bastian Koppelmann
Sorry ..., I did not use reply all ... On 01/10/2015 07:37 PM, Richard Henderson wrote: On 01/10/2015 08:51 AM, Bastian Koppelmann wrote: The documentation for the tcg-ops subfi, extr_i64_i32 and extr32_i64 was still missing. No, there are no such tcg ops. There are *functions* by these names

Re: [Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

2015-01-10 Thread Richard Henderson
On 01/10/2015 08:51 AM, Bastian Koppelmann wrote: > The documentation for the tcg-ops subfi, extr_i64_i32 and extr32_i64 was still > missing. No, there are no such tcg ops. There are *functions* by these names in tcg-op.h, but no opcodes. If you want to document this sort of thing, it should go

[Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

2015-01-10 Thread Bastian Koppelmann
The documentation for the tcg-ops subfi, extr_i64_i32 and extr32_i64 was still missing. Signed-off-by: Bastian Koppelmann --- tcg/README | 12 1 file changed, 12 insertions(+) diff --git a/tcg/README b/tcg/README index a550ff1..ba40023 100644 --- a/tcg/README +++ b/tcg/README @@ -1