Re: [Qemu-devel] [PATCH] target-tricore: Fix check which was always false

2015-03-25 Thread Bastian Koppelmann
On 03/25/2015 04:20 PM, Michael Tokarev wrote: 21.03.2015 16:44, Stefan Weil wrote: With a mask value of 0x0040, the result will never be 1. This fixes a Coverity warning. Might be a bit risky if the whole thing wasn't a complete no-op. I wonder maybe the whole this if statement should be

Re: [Qemu-devel] [PATCH] target-tricore: Fix check which was always false

2015-03-25 Thread Michael Tokarev
21.03.2015 16:44, Stefan Weil wrote: > With a mask value of 0x0040, the result will never be 1. > This fixes a Coverity warning. Might be a bit risky if the whole thing wasn't a complete no-op. I wonder maybe the whole this if statement should be removed.. But anyway, applied to -trivial, tha

Re: [Qemu-devel] [PATCH] target-tricore: Fix check which was always false

2015-03-25 Thread Bastian Koppelmann
Hi mjt, On 03/21/2015 02:44 PM, Stefan Weil wrote: With a mask value of 0x0040, the result will never be 1. This fixes a Coverity warning. Signed-off-by: Stefan Weil --- target-tricore/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tricore/op_help

[Qemu-devel] [PATCH] target-tricore: Fix check which was always false

2015-03-21 Thread Stefan Weil
With a mask value of 0x0040, the result will never be 1. This fixes a Coverity warning. Signed-off-by: Stefan Weil --- target-tricore/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c index 0e7b4e8..b7d18b2