Re: [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions

2013-03-31 Thread Richard Henderson
On 03/31/2013 04:50 PM, Peter Maydell wrote: >> > I'm a bit confused. This is the exact same algorithm that's used on ARM >> > and >> > i386. And as far as I can determine, all three platforms have the same >> > definition of "overflow". > I think it's not quite the same as ARM because the two a

Re: [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions

2013-03-31 Thread Aurelien Jarno
On Mon, Apr 01, 2013 at 12:50:58AM +0100, Peter Maydell wrote: > On 1 April 2013 00:19, Richard Henderson wrote: > > On 2013-03-30 16:54, Aurelien Jarno wrote: > >> > >> The overflow computation of nego and subf*o instructions has been broken > >> in commit ffe30937. This patch fixes it. > >> > >>

Re: [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions

2013-03-31 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 04:19:45PM -0700, Richard Henderson wrote: > On 2013-03-30 16:54, Aurelien Jarno wrote: > >The overflow computation of nego and subf*o instructions has been broken > >in commit ffe30937. This patch fixes it. > > > >With this change the PPC emulation passes the Gwenole Beauch

Re: [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions

2013-03-31 Thread Peter Maydell
On 1 April 2013 00:19, Richard Henderson wrote: > On 2013-03-30 16:54, Aurelien Jarno wrote: >> >> The overflow computation of nego and subf*o instructions has been broken >> in commit ffe30937. This patch fixes it. >> >> With this change the PPC emulation passes the Gwenole Beauchesne >> testsuit

Re: [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions

2013-03-31 Thread Richard Henderson
On 2013-03-30 16:54, Aurelien Jarno wrote: The overflow computation of nego and subf*o instructions has been broken in commit ffe30937. This patch fixes it. With this change the PPC emulation passes the Gwenole Beauchesne testsuite again. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by

[Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions

2013-03-30 Thread Aurelien Jarno
The overflow computation of nego and subf*o instructions has been broken in commit ffe30937. This patch fixes it. With this change the PPC emulation passes the Gwenole Beauchesne testsuite again. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-ppc/translate.c