Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-15 Thread Anthony Green
Peter Crosthwaite writes: > On Mon, Dec 16, 2013 at 7:02 AM, Anthony Green wrote: >> Andreas Färber writes: >> The Marin SoC currently runs on two boards: the Nexys3 (Xilinx) and DE-2 (Altera). They are pretty much identical from the software side of things. > > Ok but do they h

Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-15 Thread Peter Crosthwaite
On Mon, Dec 16, 2013 at 7:02 AM, Anthony Green wrote: > Andreas Färber writes: > >>> The Marin SoC currently runs on two boards: the Nexys3 (Xilinx) and DE-2 >>> (Altera). They are pretty much identical from the software side of >>> things. Ok but do they have the same peripheral set? We had th

Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-15 Thread Anthony Green
Andreas Färber writes: >> The Marin SoC currently runs on two boards: the Nexys3 (Xilinx) and DE-2 >> (Altera). They are pretty much identical from the software side of >> things. Marin currently provides the UART, PIC, 7 segment display and >> timer devices, as well as various memory controlle

Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-15 Thread Andreas Färber
Hi, Am 15.12.2013 13:48, schrieb Anthony Green: > Peter Crosthwaite writes: >> On Sun, Dec 15, 2013 at 1:59 PM, Anthony Green wrote: >>> diff --git a/hw/moxie/marin.c b/hw/moxie/marin.c >>> new file mode 100644 >>> index 000..0a998e4 >>> --- /dev/null >>> +++ b/hw/moxie/marin.c >>> @@ -0,0 +

Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-15 Thread Andreas Färber
Am 15.12.2013 13:48, schrieb Anthony Green: > Peter Crosthwaite writes: >> On Sun, Dec 15, 2013 at 1:59 PM, Anthony Green wrote: >>> diff --git a/hw/moxie/marin.c b/hw/moxie/marin.c >>> new file mode 100644 >>> index 000..0a998e4 >>> --- /dev/null >>> +++ b/hw/moxie/marin.c [...] >>> +static

Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-15 Thread Anthony Green
Peter - thank you for taking the time to review my patch. Comments below. Peter Crosthwaite writes: > Hi Anthony, > > On Sun, Dec 15, 2013 at 1:59 PM, Anthony Green wrote: >> >> This adds initial support for the Marin SoC, including the SoC's uart >> interface. >> >> >> Signed-off-by: Anthony

Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-14 Thread Peter Crosthwaite
On Sun, Dec 15, 2013 at 3:17 PM, Peter Crosthwaite wrote: > Hi Anthony, > > On Sun, Dec 15, 2013 at 1:59 PM, Anthony Green wrote: >> >> This adds initial support for the Marin SoC, including the SoC's uart >> interface. >> >> >> Signed-off-by: Anthony Green >> --- >> default-configs/moxie-softm

Re: [Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-14 Thread Peter Crosthwaite
Hi Anthony, On Sun, Dec 15, 2013 at 1:59 PM, Anthony Green wrote: > > This adds initial support for the Marin SoC, including the SoC's uart > interface. > > > Signed-off-by: Anthony Green > --- > default-configs/moxie-softmmu.mak | 1 + > hw/char/Makefile.objs | 1 + > hw/char/m

[Qemu-devel] [PATCH] target-moxie: Add moxie Marin SoC support

2013-12-14 Thread Anthony Green
This adds initial support for the Marin SoC, including the SoC's uart interface. Signed-off-by: Anthony Green --- default-configs/moxie-softmmu.mak | 1 + hw/char/Makefile.objs | 1 + hw/char/marin-uart.c | 198 ++ hw/moxie/Makef