Re: [Qemu-devel] [PATCH] target-mips: fix translation of MT instructions

2010-12-22 Thread Aurelien Jarno
On Fri, Oct 29, 2010 at 07:48:46AM -0700, Nathan Froyd wrote: > The translation of dmt/emt/dvpe/evpe was doing the moral equivalent of: > > int x; > ... /* no initialization of x */ > x = f (x); > > which confused later bits of TCG rather badly, leading to crashes. > > Fix the help

[Qemu-devel] [PATCH] target-mips: fix translation of MT instructions

2010-10-29 Thread Nathan Froyd
The translation of dmt/emt/dvpe/evpe was doing the moral equivalent of: int x; ... /* no initialization of x */ x = f (x); which confused later bits of TCG rather badly, leading to crashes. Fix the helpers to only return results (those instructions have no inputs), and fix the tr