Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 17:22, Leon Alrae wrote: > On 14/07/2015 16:45, Aurelien Jarno wrote: > > By the way, is this debug code really useful? I think by looking at the > > TCG code (-d in_asm,op), it's easy to determine if an instruction is > > correctly disassembled or not. > > > > For me this debug cod

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

2015-07-14 Thread Leon Alrae
On 14/07/2015 16:45, Aurelien Jarno wrote: > By the way, is this debug code really useful? I think by looking at the > TCG code (-d in_asm,op), it's easy to determine if an instruction is > correctly disassembled or not. > For me this debug code doesn't seem to be useful at all and it only clutte

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 11:08, Leon Alrae wrote: > Make use of CMPOP in floating-point compare instructions. > > Signed-off-by: Leon Alrae > --- > target-mips/translate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 7302857..4a1ffdb

[Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

2015-07-14 Thread Leon Alrae
Make use of CMPOP in floating-point compare instructions. Signed-off-by: Leon Alrae --- target-mips/translate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target-mips/translate.c b/target-mips/translate.c index 7302857..4a1ffdb 100644 --- a/target-mips/translate.c +++ b/target-mips/t