Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-12 Thread Leon Alrae
On Mon, May 09, 2016 at 06:44:00PM +0200, Aurelien Jarno wrote: > Recent versions of GCC report the following error when compiling > target-mips/helper.c: > > qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length > equal to number of elements without multiplication by element siz

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-12 Thread Christian Borntraeger
On 05/12/2016 10:06 AM, Cornelia Huck wrote: > On Thu, 12 May 2016 09:40:21 +0200 > Christian Borntraeger wrote: > >> Maybe a topic for this years QEMU summit could be to talk about >> release process and release criterias. > > +1 to that. > >> We could >> a: allow more patches , e.g. I thing

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-12 Thread Cornelia Huck
On Thu, 12 May 2016 09:40:21 +0200 Christian Borntraeger wrote: > Maybe a topic for this years QEMU summit could be to talk about > release process and release criterias. +1 to that. > We could > a: allow more patches , e.g. I thing that this patch would be have > been taken in the Linux kern

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-12 Thread Peter Maydell
On 12 May 2016 at 08:40, Christian Borntraeger wrote: > Maybe a topic for this years QEMU summit could be to talk about > release process and release criterias. Yeah, I'm happy to talk about what we could do better with releases (both on the mailing list and at the summit). A couple of notes: Th

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-12 Thread Christian Borntraeger
On 05/12/2016 12:41 AM, Peter Maydell wrote: > On 11 May 2016 at 20:28, Christian Borntraeger wrote: >> On 05/09/2016 07:57 PM, Peter Maydell wrote: >>> On 9 May 2016 at 18:55, Peter Maydell wrote: On 9 May 2016 at 18:53, Stefan Weil wrote: > I suggest to apply this patch to 2.6, if thi

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-11 Thread Peter Maydell
On 11 May 2016 at 20:28, Christian Borntraeger wrote: > On 05/09/2016 07:57 PM, Peter Maydell wrote: >> On 9 May 2016 at 18:55, Peter Maydell wrote: >>> On 9 May 2016 at 18:53, Stefan Weil wrote: I suggest to apply this patch to 2.6, if this is still possible >>> >>> It is not; sorry. > > I

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-11 Thread Christian Borntraeger
On 05/09/2016 07:57 PM, Peter Maydell wrote: > On 9 May 2016 at 18:55, Peter Maydell wrote: >> On 9 May 2016 at 18:53, Stefan Weil wrote: >>> I suggest to apply this patch to 2.6, if this is still possible >> >> It is not; sorry. I think we have delayed 2.6 already far too long (so please releas

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-09 Thread Peter Maydell
On 9 May 2016 at 18:55, Peter Maydell wrote: > On 9 May 2016 at 18:53, Stefan Weil wrote: >> I suggest to apply this patch to 2.6, if this is still possible > > It is not; sorry. Note that it's only an error if you're building with -Werror, and releases don't default to -Werror, so users using r

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-09 Thread Peter Maydell
On 9 May 2016 at 18:53, Stefan Weil wrote: > I suggest to apply this patch to 2.6, if this is still possible It is not; sorry. thanks -- PMM

Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-09 Thread Stefan Weil
Am 09.05.2016 um 18:44 schrieb Aurelien Jarno: > Recent versions of GCC report the following error when compiling > target-mips/helper.c: > > qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length > equal to number of elements without multiplication by element size > [-Wmemset-e

[Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

2016-05-09 Thread Aurelien Jarno
Recent versions of GCC report the following error when compiling target-mips/helper.c: qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size] This is indeed correct and due to a wrong usage o