Re: [Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV

2013-05-12 Thread Petar Jovanovic
; Petar Jovanovic; aurel...@aurel32.net Subject: Re: [Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV On 9 May 2013 18:28, Petar Jovanovic wrote: > @@ -2921,7 +2922,7 @@ target_ulong helper_##name(CPUMIPSState *env, > target_ulong rs, \ >

Re: [Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV

2013-05-09 Thread Peter Maydell
On 9 May 2013 18:28, Petar Jovanovic wrote: > @@ -2921,7 +2922,7 @@ target_ulong helper_##name(CPUMIPSState *env, > target_ulong rs, \ > return rt; \ > } \ >

Re: [Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV

2013-05-09 Thread Aurelien Jarno
On Thu, May 09, 2013 at 07:28:37PM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > This is a small follow-up change to "fix incorrect behaviour for INSV". > > It includes two minor modifications: > > - sizefilter is constant so it can be moved inside of the block, > - (int64_t)0x01 is

[Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV

2013-05-09 Thread Petar Jovanovic
From: Petar Jovanovic This is a small follow-up change to "fix incorrect behaviour for INSV". It includes two minor modifications: - sizefilter is constant so it can be moved inside of the block, - (int64_t)0x01 is replaced with 1LL for ease of reading. No functional change. Signed-off-by: Pe