Re: [Qemu-devel] [PATCH] target-i386: fix handling of ZF in btx instructions

2014-05-12 Thread Richard Henderson
On 05/07/2014 02:03 AM, Peter Maydell wrote: > On 6 May 2014 14:33, Dmitry Poletaev wrote: >> Eflags for bt/bts/btr/btc instructions compute as for shift(SAR) >> instructions. According to Intel A2 manual, for btx instructions zf is >> unaffected under any condition, but for SAR group, when eval

Re: [Qemu-devel] [PATCH] target-i386: fix handling of ZF in btx instructions

2014-05-07 Thread Peter Maydell
On 6 May 2014 14:33, Dmitry Poletaev wrote: > Eflags for bt/bts/btr/btc instructions compute as for shift(SAR) > instructions. According to Intel A2 manual, for btx instructions zf is > unaffected under any condition, but for SAR group, when evaluate eflags, we > compute zf. Isn't this the sam

Re: [Qemu-devel] [PATCH] target-i386: fix handling of ZF in btx instructions

2014-05-06 Thread Paolo Bonzini
Il 06/05/2014 15:33, Dmitry Poletaev ha scritto: Eflags for bt/bts/btr/btc instructions compute as for shift(SAR) instructions. According to Intel A2 manual, for btx instructions zf is unaffected under any condition, but for SAR group, when evaluate eflags, we compute zf. This patch makes zf=

[Qemu-devel] [PATCH] target-i386: fix handling of ZF in btx instructions

2014-05-06 Thread Dmitry Poletaev
Eflags for bt/bts/btr/btc instructions compute as for shift(SAR) instructions. According to Intel A2 manual, for btx instructions zf is unaffected under any condition, but for SAR group, when evaluate eflags, we compute zf. So I suggest add another group, specifically for computing eflags after