Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask

2016-02-23 Thread Eduardo Habkost
On Tue, Feb 23, 2016 at 05:16:55AM -0500, Paolo Bonzini wrote: > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Richard Henderson" > > Cc: "Paolo Bonzini" , qemu-devel@nongnu.org > > Sent: Monday, February 22, 2016 10:56:03 PM > > Subject: Re: [PATCH] target-i386: fix con

Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask

2016-02-23 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Richard Henderson" > Cc: "Paolo Bonzini" , qemu-devel@nongnu.org > Sent: Monday, February 22, 2016 10:56:03 PM > Subject: Re: [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask > > On Mon, Feb 22, 2016 at 11:14:44AM -0

Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask

2016-02-22 Thread Eduardo Habkost
On Mon, Feb 22, 2016 at 11:14:44AM -0800, Richard Henderson wrote: > On 02/22/2016 02:19 AM, Paolo Bonzini wrote: > > The xsave and xrstor helpers are accessing the x86_ext_save_areas array > > using a bit mask instead of a bit position. Provide two sets of XSTATE_* > > definitions and use XSTATE_

Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask

2016-02-22 Thread Richard Henderson
On 02/22/2016 02:19 AM, Paolo Bonzini wrote: > The xsave and xrstor helpers are accessing the x86_ext_save_areas array > using a bit mask instead of a bit position. Provide two sets of XSTATE_* > definitions and use XSTATE_*_BIT when a bit position is requested. Whoops. This patch is fine, Revi

[Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask

2016-02-22 Thread Paolo Bonzini
The xsave and xrstor helpers are accessing the x86_ext_save_areas array using a bit mask instead of a bit position. Provide two sets of XSTATE_* definitions and use XSTATE_*_BIT when a bit position is requested. Signed-off-by: Paolo Bonzini --- target-i386/cpu.c| 29 ++--