Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1]

2014-11-26 Thread Paolo Bonzini
On 26/11/2014 12:40, Eduardo Habkost wrote: > On Wed, Nov 26, 2014 at 10:20:12AM +0100, Paolo Bonzini wrote: >> >> >> On 25/11/2014 21:02, Paolo Bonzini wrote: > +static const char *cpuid_xsave_feature_name[] = { > +"xsaveopt", "xsavec", "xgetbv1", "xsaves", None of the abov

Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1]

2014-11-26 Thread Eduardo Habkost
On Wed, Nov 26, 2014 at 10:20:12AM +0100, Paolo Bonzini wrote: > > > On 25/11/2014 21:02, Paolo Bonzini wrote: > > > > +static const char *cpuid_xsave_feature_name[] = { > > > > +"xsaveopt", "xsavec", "xgetbv1", "xsaves", > > > > > > None of the above features introduce any new state that mi

Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1]

2014-11-26 Thread Paolo Bonzini
On 25/11/2014 21:02, Paolo Bonzini wrote: > > > +static const char *cpuid_xsave_feature_name[] = { > > > +"xsaveopt", "xsavec", "xgetbv1", "xsaves", > > > > None of the above features introduce any new state that might need to be > > migrated, or will require other changes in QEMU to work, r

Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1]

2014-11-25 Thread Paolo Bonzini
On 25/11/2014 19:45, Eduardo Habkost wrote: >> > +static const char *cpuid_xsave_feature_name[] = { >> > +"xsaveopt", "xsavec", "xgetbv1", "xsaves", > None of the above features introduce any new state that might need to be > migrated, or will require other changes in QEMU to work, right? >

Re: [Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1]

2014-11-25 Thread Eduardo Habkost
On Tue, Nov 25, 2014 at 06:35:42PM +0100, Paolo Bonzini wrote: > These represent xsave-related capabilities of the processor, and KVM may > or may not support them. > > Add feature bits so that they are considered by "-cpu ...,enforce", and use > the new feature work instead of calling kvm_arch_ge

[Qemu-devel] [PATCH] target-i386: add feature flags for CPUID[EAX=0xd, ECX=1]

2014-11-25 Thread Paolo Bonzini
These represent xsave-related capabilities of the processor, and KVM may or may not support them. Add feature bits so that they are considered by "-cpu ...,enforce", and use the new feature work instead of calling kvm_arch_get_supported_cpuid. Signed-off-by: Paolo Bonzini --- target-i386/cpu.c