Re: [Qemu-devel] [PATCH] target-i386: Compute all flag data inside %cl != 0 test.

2011-09-08 Thread malc
On Thu, 8 Sep 2011, Richard Henderson wrote: > The (x << (cl - 1)) quantity is only used if CL != 0. Move the > computation of that quantity nearer its use. > > This avoids the creation of undefined TCG operations when the > constant propagation optimization proves that CL == 0, and thus > CL-1

[Qemu-devel] [PATCH] target-i386: Compute all flag data inside %cl != 0 test.

2011-09-08 Thread Richard Henderson
The (x << (cl - 1)) quantity is only used if CL != 0. Move the computation of that quantity nearer its use. This avoids the creation of undefined TCG operations when the constant propagation optimization proves that CL == 0, and thus CL-1 is outside the range [0-wordsize). Signed-off-by: Richard