Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup

2009-11-02 Thread Juha.Riihimaki
On Nov 1, 2009, at 02:08, ext Laurent Desnogues wrote: > On Thu, Oct 29, 2009 at 3:01 PM, wrote: >> From: Juha Riihimäki >> >> TCG temporary variable handling in target-arm/translate.c is >> currently >> somewhat inconsistent; some functions allocate new temporaries that >> the >> calling f

Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup

2009-10-31 Thread Laurent Desnogues
On Thu, Oct 29, 2009 at 3:01 PM, wrote: > From: Juha Riihimäki > > TCG temporary variable handling in target-arm/translate.c is currently > somewhat inconsistent; some functions allocate new temporaries that the > calling function is expected to free and some other functions free > temporaries t

Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup

2009-10-29 Thread Laurent Desnogues
On Thu, Oct 29, 2009 at 7:22 PM, Stuart Brady wrote: > On Thu, Oct 29, 2009 at 04:01:15PM +0200, juha.riihim...@nokia.com wrote: >> >> -static inline TCGv gen_ld8s(TCGv addr, int index) >> +static inline void gen_ld8s(TCGv ret, TCGv addr, int index) >>  { >> -    TCGv tmp = new_tmp(); >> -    tcg_

Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup

2009-10-29 Thread Stuart Brady
On Thu, Oct 29, 2009 at 04:01:15PM +0200, juha.riihim...@nokia.com wrote: > > -static inline TCGv gen_ld8s(TCGv addr, int index) > +static inline void gen_ld8s(TCGv ret, TCGv addr, int index) > { > -TCGv tmp = new_tmp(); > -tcg_gen_qemu_ld8s(tmp, addr, index); > -return tmp; > +t