Re: [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary

2011-04-27 Thread Aurelien Jarno
On Mon, Apr 25, 2011 at 01:23:58AM +, YuYeon Oh wrote: > target-arm: fix LDMIA bug on page boundary > > When consecutive memory locations are on page boundary, a base register may be > loaded before page fault occurs. After page fault handling, it losts the > memory > location information. To

Re: [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary

2011-04-26 Thread Peter Maydell
On 25 April 2011 02:23, YuYeon Oh wrote: > target-arm: fix LDMIA bug on page boundary (You don't need to repeat the Subject summary line in the body, it makes the git changelog look a bit odd when the patch is applied with 'git am'). > When consecutive memory locations are on page boundary, a ba

[Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary

2011-04-24 Thread YuYeon Oh
target-arm: fix LDMIA bug on page boundary When consecutive memory locations are on page boundary, a base register may be loaded before page fault occurs. After page fault handling, it losts the memory location information. To solve this problem, loading a base register has to put back. Signed-o

Re: [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary

2011-04-24 Thread YuYeon Oh
2011/4/24 Peter Maydell >Thanks for finding this. I agree the fix is required, but I think I'd >prefer it if the thumb code for this case handled it in the same way >the disas_arm_insn() code does: > > loaded_base = 0; > TCGV_UNUSED(loaded_var); > [...] > tmp = gen_ld32(addr, IS_USER(s))

Re: [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary

2011-04-24 Thread Peter Maydell
2011/4/24 오유연 : > When consecutive memory locations are on page boundary, a base register may be > loaded before page fault occurs. After page fault handling, it losts the > memory > location information. To solve this problem, loading a base register has to > put back. Thanks for finding this.

[Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary

2011-04-24 Thread 오유연
When consecutive memory locations are on page boundary, a base register may be loaded before page fault occurs. After page fault handling, it losts the memory location information. To solve this problem, loading a base register has to put back. Signed-off-by: Yuyeon Oh --- target-arm/translate.