Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

2014-05-29 Thread Ard Biesheuvel
On 29 May 2014 18:46, Peter Maydell wrote: > On 25 March 2014 16:27, Ard Biesheuvel wrote: >> This adds support for the SHA1 and SHA256 instructions that are available >> on some v8 implementations of Aarch32. >> >> Signed-off-by: Ard Biesheuvel > > Apologies for the incredibly late review; I wa

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

2014-05-29 Thread Peter Maydell
On 25 March 2014 16:27, Ard Biesheuvel wrote: > This adds support for the SHA1 and SHA256 instructions that are available > on some v8 implementations of Aarch32. > > Signed-off-by: Ard Biesheuvel Apologies for the incredibly late review; I was hugely busy back in March and then this slipped thr

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

2014-03-25 Thread Peter Maydell
On 25 March 2014 17:18, Peter Maydell wrote: > On 25 March 2014 16:46, Andreas Färber wrote: >> Am 25.03.2014 17:27, schrieb Ard Biesheuvel: >>> @@ -630,6 +630,8 @@ enum arm_features { >>> ARM_FEATURE_V8_AES, /* implements AES part of v8 Crypto Extensions */ >>> ARM_FEATURE_CBAR, /* has

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

2014-03-25 Thread Peter Maydell
On 25 March 2014 16:46, Andreas Färber wrote: > Am 25.03.2014 17:27, schrieb Ard Biesheuvel: >> @@ -630,6 +630,8 @@ enum arm_features { >> ARM_FEATURE_V8_AES, /* implements AES part of v8 Crypto Extensions */ >> ARM_FEATURE_CBAR, /* has cp15 CBAR */ >> ARM_FEATURE_CRC, /* ARMv8 CRC

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

2014-03-25 Thread Andreas Färber
Am 25.03.2014 17:27, schrieb Ard Biesheuvel: > This adds support for the SHA1 and SHA256 instructions that are available > on some v8 implementations of Aarch32. > > Signed-off-by: Ard Biesheuvel > --- > target-arm/cpu.c | 2 + > target-arm/cpu.h | 2 + > target-arm/crypt

[Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

2014-03-25 Thread Ard Biesheuvel
This adds support for the SHA1 and SHA256 instructions that are available on some v8 implementations of Aarch32. Signed-off-by: Ard Biesheuvel --- target-arm/cpu.c | 2 + target-arm/cpu.h | 2 + target-arm/crypto_helper.c | 257 +++-