Re: [Qemu-devel] [PATCH] target-arm: add dump-guest-memory support

2014-12-24 Thread Peter Maydell
On 24 December 2014 at 16:54, Rabin Vincent wrote: > On Tue, Dec 23, 2014 at 11:45:00PM +, Peter Maydell wrote: >> Assuming the answer is "still 64 bit core dump" you need >> to do something here to sync the 32 bit TCG state into the >> 64 bit xregs array. (KVM can take care of itself.) > > I

Re: [Qemu-devel] [PATCH] target-arm: add dump-guest-memory support

2014-12-24 Thread Rabin Vincent
On Tue, Dec 23, 2014 at 11:45:00PM +, Peter Maydell wrote: > On 23 December 2014 at 23:29, Rabin Vincent wrote: > > +static size_t round4(size_t size) > > +{ > > +return ((size + 3) / 4) * 4; > > +} > > Is this different from ROUND_UP(size, 4) ? > If we can use the standard macro from the

Re: [Qemu-devel] [PATCH] target-arm: add dump-guest-memory support

2014-12-23 Thread Peter Maydell
On 23 December 2014 at 23:29, Rabin Vincent wrote: > Enable support for the dump-guest-memory command on ARM and AArch64. > The dumped files can be analyzed with crash or similar tools. > > Signed-off-by: Rabin Vincent Thanks -- looks pretty good. One nit and some annoying corner cases you may n

[Qemu-devel] [PATCH] target-arm: add dump-guest-memory support

2014-12-23 Thread Rabin Vincent
Enable support for the dump-guest-memory command on ARM and AArch64. The dumped files can be analyzed with crash or similar tools. Signed-off-by: Rabin Vincent --- target-arm/Makefile.objs | 2 +- target-arm/arch_dump.c | 148 +++ target-arm/cpu-qo