Re: [Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming

2011-10-24 Thread Peter Maydell
On 22 October 2011 11:33, Andreas Färber wrote: > Am 22.10.2011 12:20, schrieb Peter Maydell: >> On 3 October 2011 11:32, Andreas Färber wrote: >>> -#define ARM_CPUID_ARM1136     0x4117b363 >>> -#define ARM_CPUID_ARM1136_R2  0x4107b362 >>> +#define ARM_CPUID_ARM1136_R1P3 0x4117b363 >>> +#define A

Re: [Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming

2011-10-22 Thread Andreas Färber
Am 22.10.2011 12:20, schrieb Peter Maydell: > On 3 October 2011 11:32, Andreas Färber wrote: >> -#define ARM_CPUID_ARM1136 0x4117b363 >> -#define ARM_CPUID_ARM1136_R2 0x4107b362 >> +#define ARM_CPUID_ARM1136_R1P3 0x4117b363 >> +#define ARM_CPUID_ARM1136_R0P2 0x4107b362 > > I don't think the

Re: [Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming

2011-10-22 Thread Peter Maydell
On 3 October 2011 11:32, Andreas Färber wrote: > -#define ARM_CPUID_ARM1136     0x4117b363 > -#define ARM_CPUID_ARM1136_R2  0x4107b362 > +#define ARM_CPUID_ARM1136_R1P3 0x4117b363 > +#define ARM_CPUID_ARM1136_R0P2 0x4107b362 I don't think the patchlevels are important enough to memorialise in the

Re: [Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming

2011-10-22 Thread Andreas Färber
Am 03.10.2011 12:32, schrieb Andreas Färber: > -cpu arm1136-r2 is commented to in fact be ARM1136 r0p2, whereas > -cpu arm1136 seems to be ARM1136 r1p3 according to the MIDR value. > > The CPUID values contain major and minor revision numbers (rnpn) and > are never used with a mask, so are specifi

[Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming

2011-10-03 Thread Andreas Färber
-cpu arm1136-r2 is commented to in fact be ARM1136 r0p2, whereas -cpu arm1136 seems to be ARM1136 r1p3 according to the MIDR value. The CPUID values contain major and minor revision numbers (rnpn) and are never used with a mask, so are specific to the chosen revision. Rename the CPUID preprocessor