Re: [Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long

2014-03-10 Thread Richard Henderson
On 03/10/2014 09:06 AM, Peter Maydell wrote: > which I am proposing would be better written as > tcg_gen_exit_tb(NULL, 0) > tcg_gen_exit_tb(tb, 0) > tcg_gen_exit_tb(tb, n) > > and letting tcg_gen_exit_tb() do the cast to uintptr_t > and add. Oh, I see. Yes, that would be fine. r~

Re: [Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long

2014-03-10 Thread Peter Maydell
On 10 March 2014 16:01, Richard Henderson wrote: > On 03/10/2014 05:08 AM, Peter Maydell wrote: >> A quick grep of the uses of tcg_gen_exit_tb() suggests >> we would be better to change this function to take >> (TranslationBlock *tb, int tb_exit_code), possibly >> also with a special case for 0 if

Re: [Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long

2014-03-10 Thread Richard Henderson
On 03/10/2014 05:08 AM, Peter Maydell wrote: > A quick grep of the uses of tcg_gen_exit_tb() suggests > we would be better to change this function to take > (TranslationBlock *tb, int tb_exit_code), possibly > also with a special case for 0 if "tcg_gen_exit_tb(NULL, 0)" > seems too verbose. No, si

Re: [Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long

2014-03-10 Thread Peter Maydell
On 5 March 2014 18:14, Richard Henderson wrote: > Fixes a build error when these are different, e.g. x32. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell A quick grep of the uses of tcg_gen_exit_tb() suggests we would be better to change this function to take (TranslationBlock

[Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long

2014-03-05 Thread Richard Henderson
Fixes a build error when these are different, e.g. x32. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 08ac659..37e05e8 100644 --- a/target-arm/trans