Re: [Qemu-devel] [PATCH] target-arm/translate: Fix RRX operands

2012-10-17 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 05:43:55PM +0100, Peter Maydell wrote: > On 16 October 2012 10:15, Peter Crosthwaite > wrote: > > Instructions that both use the RRX second operand and update CS were > > incorrect, as the Carry flag was updated too early. An example of such an > > instruction would be: > >

Re: [Qemu-devel] [PATCH] target-arm/translate: Fix RRX operands

2012-10-17 Thread Peter Maydell
On 16 October 2012 10:15, Peter Crosthwaite wrote: > Instructions that both use the RRX second operand and update CS were > incorrect, as the Carry flag was updated too early. An example of such an > instruction would be: > > ands r12,r13,RRX > > Ands, because of the "s" flag will update the carry

[Qemu-devel] [PATCH] target-arm/translate: Fix RRX operands

2012-10-16 Thread Peter Crosthwaite
Instructions that both use the RRX second operand and update CS were incorrect, as the Carry flag was updated too early. An example of such an instruction would be: ands r12,r13,RRX Ands, because of the "s" flag will update the carry flag. But the RRX second operand rotates through the C flag whi