Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-19 Thread Sergey Fedorov
On 19.10.2015 20:04, Richard Henderson wrote: > On 10/19/2015 01:04 AM, Sergey Fedorov wrote: >> On 19.10.2015 01:46, Richard Henderson wrote: >>> On 10/16/2015 04:08 AM, Sergey Fedorov wrote: On 16.10.2015 04:14, Richard Henderson wrote: > On 10/16/2015 03:36 AM, Peter Maydell wrote:

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-19 Thread Richard Henderson
On 10/19/2015 01:04 AM, Sergey Fedorov wrote: On 19.10.2015 01:46, Richard Henderson wrote: On 10/16/2015 04:08 AM, Sergey Fedorov wrote: On 16.10.2015 04:14, Richard Henderson wrote: On 10/16/2015 03:36 AM, Peter Maydell wrote: On 14 October 2015 at 22:02, Richard Henderson wrote: On 10/15

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-19 Thread Sergey Fedorov
On 19.10.2015 01:46, Richard Henderson wrote: > On 10/16/2015 04:08 AM, Sergey Fedorov wrote: >> On 16.10.2015 04:14, Richard Henderson wrote: >>> On 10/16/2015 03:36 AM, Peter Maydell wrote: On 14 October 2015 at 22:02, Richard Henderson wrote: > On 10/15/2015 06:34 AM, Peter Maydel

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-18 Thread Richard Henderson
On 10/16/2015 04:08 AM, Sergey Fedorov wrote: On 16.10.2015 04:14, Richard Henderson wrote: On 10/16/2015 03:36 AM, Peter Maydell wrote: On 14 October 2015 at 22:02, Richard Henderson wrote: On 10/15/2015 06:34 AM, Peter Maydell wrote: This is still the same cryptic comment we have in the t

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-16 Thread Sergey Fedorov
On 16.10.2015 19:36, Sergey Fedorov wrote: > On 16.10.2015 17:08, Sergey Fedorov wrote: >> On 16.10.2015 04:14, Richard Henderson wrote: >>> On 10/16/2015 03:36 AM, Peter Maydell wrote: On 14 October 2015 at 22:02, Richard Henderson wrote: > On 10/15/2015 06:34 AM, Peter Maydell wrote: >>

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-16 Thread Sergey Fedorov
On 16.10.2015 17:08, Sergey Fedorov wrote: > On 16.10.2015 04:14, Richard Henderson wrote: >> On 10/16/2015 03:36 AM, Peter Maydell wrote: >>> On 14 October 2015 at 22:02, Richard Henderson wrote: On 10/15/2015 06:34 AM, Peter Maydell wrote: > This is still the same cryptic comment we hav

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-16 Thread Sergey Fedorov
On 16.10.2015 04:14, Richard Henderson wrote: > On 10/16/2015 03:36 AM, Peter Maydell wrote: >> On 14 October 2015 at 22:02, Richard Henderson wrote: >>> On 10/15/2015 06:34 AM, Peter Maydell wrote: This is still the same cryptic comment we have in the targets which do do this. Can

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 02:14, Richard Henderson wrote: > Heh. Fair enough. How about > > /* The address covered by the breakpoint must be included in > [tb->pc, tb->pc + tb->size) in order to for it to be > properly cleared -- thus we increment the PC here so that > the logic set

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-15 Thread Richard Henderson
On 10/16/2015 03:36 AM, Peter Maydell wrote: On 14 October 2015 at 22:02, Richard Henderson wrote: On 10/15/2015 06:34 AM, Peter Maydell wrote: This is still the same cryptic comment we have in the targets which do do this. Can we have something that is a bit more explanatory about what is go

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-15 Thread Peter Maydell
On 14 October 2015 at 22:02, Richard Henderson wrote: > On 10/15/2015 06:34 AM, Peter Maydell wrote: >> >> This is still the same cryptic comment we have in the >> targets which do do this. Can we have something >> that is a bit more explanatory about what is going on and >> why we need to do this

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-14 Thread Richard Henderson
On 10/15/2015 06:34 AM, Peter Maydell wrote: This is still the same cryptic comment we have in the targets which do do this. Can we have something that is a bit more explanatory about what is going on and why we need to do this, please? Suggestions? (Also explaining what the number you need t

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-14 Thread Peter Maydell
On 13 October 2015 at 23:10, Richard Henderson wrote: > Some targets already had this within their logic, but make sure > it's present for all targets. > > Signed-off-by: Richard Henderson > --- > target-alpha/translate.c | 3 +++ > target-cris/translate.c | 3 +++ > target-i386/trans

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-14 Thread Sergey Fedorov
On 14.10.2015 01:10, Richard Henderson wrote: > Some targets already had this within their logic, but make sure > it's present for all targets. > > Signed-off-by: Richard Henderson Reported-by: Sergey Fedorov Thanks, Sergey > --- > target-alpha/translate.c | 3 +++ > target-cris/translat

[Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-13 Thread Richard Henderson
Some targets already had this within their logic, but make sure it's present for all targets. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 3 +++ target-cris/translate.c | 3 +++ target-i386/translate.c | 3 +++ target-lm32/translate.c | 3 +++ target-m6