Re: [Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub

2017-06-07 Thread Max Filippov
On Tue, Jun 6, 2017 at 5:55 PM, Richard Henderson wrote: > On 06/03/2017 02:19 AM, Max Filippov wrote: >> >> +memset(mem_buf, 0, reg->size); >> +return reg->size; >> return 0; > > Leaving a dead return. Meh ): Thanks for the review. Will send a fix. -- Thanks. -- Max

Re: [Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub

2017-06-06 Thread Richard Henderson
On 06/03/2017 02:19 AM, Max Filippov wrote: +memset(mem_buf, 0, reg->size); +return reg->size; return 0; Leaving a dead return. r~

[Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub

2017-06-03 Thread Max Filippov
Xtensa cores may have registers of types/sizes not supported by the gdbstub accessors. Ignore writes to such registers and return zero on read, but always return correct register size, so that gdb on the other side is able to access all registers in the packet holding unsupported registers in the m