Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread Thomas Huth
On 20.06.2017 01:44, Richard Henderson wrote: > On 06/19/2017 01:08 AM, Thomas Huth wrote: >>> +/* Sanity check the function code and storage characteristic. */ >>> +if (fc > 1 || sc > 3) { >>> +if (!s390_has_feat(S390_FEAT_COMPARE_AND_SWAP_AND_STORE_2)) { >>> +goto spe

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread Richard Henderson
On 06/19/2017 01:08 AM, Thomas Huth wrote: +/* Sanity check the function code and storage characteristic. */ +if (fc > 1 || sc > 3) { +if (!s390_has_feat(S390_FEAT_COMPARE_AND_SWAP_AND_STORE_2)) { +goto spec_exception; +} +if (fc > 2 || sc > 4 || (fc =

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread Richard Henderson
On 06/19/2017 01:08 AM, Thomas Huth wrote: +/* Sanity check the function code and storage characteristic. */ +if (fc > 1 || sc > 3) { +if (!s390_has_feat(S390_FEAT_COMPARE_AND_SWAP_AND_STORE_2)) { +goto spec_exception; +} +if (fc > 2 || sc > 4 || (fc =

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread Christian Borntraeger
On 06/19/2017 02:52 PM, David Hildenbrand wrote: > On 19.06.2017 14:47, Christian Borntraeger wrote: >> On 06/19/2017 02:41 PM, David Hildenbrand wrote: >>> On 19.06.2017 14:33, Christian Borntraeger wrote: On 06/19/2017 02:05 PM, David Hildenbrand wrote: > On 19.06.2017 12:03, David Hilde

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread David Hildenbrand
On 19.06.2017 14:47, Christian Borntraeger wrote: > On 06/19/2017 02:41 PM, David Hildenbrand wrote: >> On 19.06.2017 14:33, Christian Borntraeger wrote: >>> On 06/19/2017 02:05 PM, David Hildenbrand wrote: On 19.06.2017 12:03, David Hildenbrand wrote: > On 15.06.2017 22:37, Richard Hender

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread Christian Borntraeger
On 06/19/2017 02:41 PM, David Hildenbrand wrote: > On 19.06.2017 14:33, Christian Borntraeger wrote: >> On 06/19/2017 02:05 PM, David Hildenbrand wrote: >>> On 19.06.2017 12:03, David Hildenbrand wrote: On 15.06.2017 22:37, Richard Henderson wrote: > There are no uses in a Linux system wit

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread David Hildenbrand
On 19.06.2017 14:33, Christian Borntraeger wrote: > On 06/19/2017 02:05 PM, David Hildenbrand wrote: >> On 19.06.2017 12:03, David Hildenbrand wrote: >>> On 15.06.2017 22:37, Richard Henderson wrote: There are no uses in a Linux system with which to test, but it Looks Right by my reading

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread Christian Borntraeger
On 06/19/2017 02:05 PM, David Hildenbrand wrote: > On 19.06.2017 12:03, David Hildenbrand wrote: >> On 15.06.2017 22:37, Richard Henderson wrote: >>> There are no uses in a Linux system with which to test, >>> but it Looks Right by my reading of the PoO. >> >> I am using next.git/master with this p

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread David Hildenbrand
On 19.06.2017 12:03, David Hildenbrand wrote: > On 15.06.2017 22:37, Richard Henderson wrote: >> There are no uses in a Linux system with which to test, >> but it Looks Right by my reading of the PoO. > > I am using next.git/master with this patch applied: > https://git.kernel.org/pub/scm/linux/ke

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread David Hildenbrand
On 15.06.2017 22:37, Richard Henderson wrote: > There are no uses in a Linux system with which to test, > but it Looks Right by my reading of the PoO. I am using next.git/master with this patch applied: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=features&id=8aa8680aa3

Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-19 Thread Thomas Huth
On 15.06.2017 22:37, Richard Henderson wrote: > There are no uses in a Linux system with which to test, > but it Looks Right by my reading of the PoO. > > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 1 + > target/s390x/insn-data.def | 2 + > target/s390x/mem_helper.

[Qemu-devel] [PATCH] target/s390x: Implement CSST

2017-06-15 Thread Richard Henderson
There are no uses in a Linux system with which to test, but it Looks Right by my reading of the PoO. Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 + target/s390x/mem_helper.c | 189 + target